Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85563?usp=email )
Change subject: mb/google/rauru: Implement regulator interface
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/mainboard/google/rauru/regulator.c:
https://review.coreboot.org/c/coreboot/+/85563/comment/28a9e3d7_e16d0d40?usp... :
PS2, Line 31: if (id == MT6373_VMCH)
: mt6373_set_vmch_voltage(voltage_uv);
: else if (id == MT6373_VMC)
: mt6373_set_vmc_voltage(voltage_uv);
Use switch.
https://review.coreboot.org/c/coreboot/+/85563/comment/111d5eb6_c3f1c9e3?usp... :
PS2, Line 36: BIOS_WARNING
This should be an error, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3cad68dbb2c5873c4e00066da18b1593b88ff499
Gerrit-Change-Number: 85563
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 12 Dec 2024 07:18:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes