Attention is currently required from: Michał Żygowski, Arthur Heymans. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52781 )
Change subject: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution ......................................................................
Patch Set 12:
(2 comments)
File src/cpu/amd/agesa/family14/model_14_init.c:
https://review.coreboot.org/c/coreboot/+/52781/comment/971a5b6c_f3b7c064 PS7, Line 24: if (acpi_is_wakeup_s3()) { : restore_mtrr();
This will result in different MTRR solutions at resume.
It looks like the MTRRs are backed up in `BS_POST_DEVICE` (`amd_bs_post_device`), after they're initialized, so the same solution should be restored here, or am I missing something?
https://review.coreboot.org/c/coreboot/+/52781/comment/8d685da1_a4ee4c2b PS7, Line 32: /* : * Enable ROM caching on BSP we just lost when creating MTRR solution, for : * faster execution : */ : if (boot_cpu()) { : mtrr_use_temp_range(OPTIMAL_CACHE_ROM_BASE, OPTIMAL_CACHE_ROM_SIZE, : MTRR_TYPE_WRPROT); : }
code is not executed from ROM at this point.
Done