Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60396 )
Change subject: soc/mediatek/mt8186: Add DDP driver ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60396/comment/1935b4c0_1525836c PS3, Line 11: Is there a Linux kernel driver, and are they quite similar?
File src/soc/mediatek/mt8186/ddp.c:
https://review.coreboot.org/c/coreboot/+/60396/comment/14f45e12_03251b08 PS3, Line 13: * POSTMASK0->DITHER->DSI0 Fits on the line above?
https://review.coreboot.org/c/coreboot/+/60396/comment/cf9157f1_51f868e3 PS3, Line 136: /* Turn off M4U port. */ Remove dot/period at the end?
-
Paul Menzel (Code Review)