Attention is currently required from: Nico Huber.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79945?usp=email )
Change subject: [NEEDS TEST] region: Check for overflows after offset calculation ......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79945/comment/ef9b2c48_912f89bb : PS3, Line 25: return region_end(inner) - 1 >= region_offset(inner) &&
Technically, we don't have to decide. It's just a little more code to […]
It's probably fine, but is it still necessary if you submit your "hide members" patch? Then we should be okay to just rely on the assert in `region_create()`, right?