Attention is currently required from: Paul Menzel. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62809 )
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62809/comment/4a6a137c_6d8f313b PS2, Line 13:
- Testing details like payload and OS should be documented. […]
1. It's a new variant. It boots to linux with the code my friend gave me, but we need to verify this commit also boots.
2. Do you mean the differences between the two boards?
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62809/comment/ca17661a_5d2eedad PS2, Line 48: default "z220_cmt_workstation" if BOARD_HP_Z220_CMT_WORKSTATION
Sort all the entries?
All 2 entries? Not worth pushing again IMHO. But if you force me to redo the commit message, I might slip this in to reorder two lines of code.
-
Damien Zammit (Code Review)