Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Nick Vaccaro, Karthik Ramasubramanian. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Nick Vaccaro, Karthik Ramasubramanian,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56733
to review the following change.
Change subject: Revert "mb/google/brya/variants/brya0: add PL4 values for different SKUs" ......................................................................
Revert "mb/google/brya/variants/brya0: add PL4 values for different SKUs"
This reverts commit e7f3e6a0558e6783916335bacb69655f7ac1493f.
Reason for revert: Depends on CB:56915 (not merged)
Change-Id: Icb971eaa8142fe9cdb0dca41951c4aa90909d5b6 --- M src/mainboard/google/brya/variants/brya0/ramstage.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/56733/1
diff --git a/src/mainboard/google/brya/variants/brya0/ramstage.c b/src/mainboard/google/brya/variants/brya0/ramstage.c index 9a4fc28..0da8eb1 100644 --- a/src/mainboard/google/brya/variants/brya0/ramstage.c +++ b/src/mainboard/google/brya/variants/brya0/ramstage.c @@ -4,11 +4,11 @@ #include <device/pci_ids.h>
const struct cpu_power_limits limits[] = { - /* SKU_ID, pl1_min, pl1_max, pl2_min, pl2_max, pl4 */ - /* All values are for baseline config as per bug:191906315 comment #10 */ - { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 3000, 15000, 39000, 39000, 100000}, - { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 4000, 28000, 43000, 43000, 105000}, - { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 5000, 45000, 80000, 80000, 159000}, + /* SKU_ID, pl1_min, pl1_max, pl2_min, pl2_max */ + /* PL2 values are for baseline config as per bug:191906315 comment #10 */ + { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 3000, 15000, 39000, 39000 }, + { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 4000, 28000, 43000, 43000 }, + { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 5000, 45000, 80000, 80000 }, };
void variant_devtree_update(void)