Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Update checkpatch.pl mentions to designate 96 columns ......................................................................
Documentation: Update checkpatch.pl mentions to designate 96 columns
We typically call checkpatch.pl through make lint which properly adds the option to tell checkpatch that our lines may be 96 columns long.
However there's one mention of calling checkpatch directly and that confuses people with complaints about overly long lines that exceed 80 columns.
Change-Id: If21e925d2d2394c876724a44b0e23c9b2744c56b Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/tutorial/part2.md 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43450/1
diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index 5ab210a..c55f35c 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -109,7 +109,8 @@ if you want to run `make lint` on a specific directory, run:
for file in $(git ls-files | grep <filepath>); do \ - util/lint/checkpatch.pl --file $file --terse; done + util/lint/checkpatch.pl --max-line-length 96 --file $file --terse; \ + done
where `filepath` is the filepath of the directory (ex. `src/cpu/amd/car`).
Patrick Georgi has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Remove mention of manual checkpatch.pl invocation ......................................................................
Documentation: Remove mention of manual checkpatch.pl invocation
We typically call checkpatch.pl through make lint which properly adds the option to tell checkpatch that our lines may be 96 columns long.
However there's one mention of calling checkpatch directly and that confuses people with complaints about overly long lines that exceed 80 columns.
The lint test that runs checkpatch (and with the right options) can also be used on a per-directory basis, so offer that instead.
Change-Id: If21e925d2d2394c876724a44b0e23c9b2744c56b Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/tutorial/part2.md 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/43450/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Remove mention of manual checkpatch.pl invocation ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Remove mention of manual checkpatch.pl invocation ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Remove mention of manual checkpatch.pl invocation ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43450 )
Change subject: Documentation: Remove mention of manual checkpatch.pl invocation ......................................................................
Documentation: Remove mention of manual checkpatch.pl invocation
We typically call checkpatch.pl through make lint which properly adds the option to tell checkpatch that our lines may be 96 columns long.
However there's one mention of calling checkpatch directly and that confuses people with complaints about overly long lines that exceed 80 columns.
The lint test that runs checkpatch (and with the right options) can also be used on a per-directory basis, so offer that instead.
Change-Id: If21e925d2d2394c876724a44b0e23c9b2744c56b Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43450 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M Documentation/tutorial/part2.md 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index 5ab210a..4ac8574 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -108,8 +108,7 @@ the repository by running `make lint` in the coreboot directory. Alternatively, if you want to run `make lint` on a specific directory, run:
- for file in $(git ls-files | grep <filepath>); do \ - util/lint/checkpatch.pl --file $file --terse; done + util/lint/lint-007-checkpatch <filepath>
where `filepath` is the filepath of the directory (ex. `src/cpu/amd/car`).