Attention is currently required from: Maximilian Brune.
Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email )
Change subject: lib/device_tree.c: Fix results length check ......................................................................
Patch Set 1:
(1 comment)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/83085/comment/997a92f9_34423bc8?usp... : PS1, Line 363: if (count_results > results_len) { I don't think this is correct? `results_len` X means that the `results` array has X entries, which means that `results[0]` to `results[X-1]` are valid entries. With this patch, we won't error out here if `count_results` is also X. That means below in line 372 we will access `results[X]`, which is invalid.