Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74396 )
Change subject: cpu,soc/intel: Sync ACPI CPU object implementations ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/cpu/intel/haswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/74396/comment/330f73fa_31f90741 PS2, Line 337: for (int cpu_id = 0; cpu_id < numcpus; cpu_id++) {
it's more common in coreboot to define the local variables at the beginning of the function and not inside the for loop. since we're at a new enough c standard, this isn't really an issue though. i don't have too strong opinions about this, so if you'd like to keep it the way it is right now, fell free to just ack this comment
I prefer it inside loops actually. It reduces the scope of the variable.
-
Arthur Heymans (Code Review)