Attention is currently required from: Elyes Haouas, Felix Singer, Jakub Czapiga, Martin L Roth, Maximilian Brune, Nico Huber.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: stddef.h: Introduce nullptr constant ......................................................................
Patch Set 26:
(1 comment)
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/83459/comment/8776a690_53596985?usp... : PS26, Line 25: #define nullptr ((void *)0)
To be clear, my concern is only about the `#define nullptr` on the old path, not the C23 path. […]
Well, the keyword `nullptr` is going to be defined for C23 and we're presumably planning to switch to that eventually. So code that uses that name as an identifier is going to have a problem anyway.
I'm not sure why we should need to argue so much about code that works differently in C17 vs C23 anyway... don't we usually just change the coreboot C standard, rather than maintain support for multiple standards? I assume CB:84489 is supposed to be a test change and will eventually go away before merging — I don't think there's a point in letting users decide this via Kconfig. At the point where we decide that we want to switch to C23 we would just do it, and then we could also remove the arguable #else clause here again. (Or we just squash all of these patches together and change things in one go, don't really care. The only important part here is that once we've switched to C23, it makes sense to redefine NULL via nullptr.)
-
Julius Werner (Code Review)