Attention is currently required from: Tarun Tuli, Jamie Ryu, Ravishankar Sarawadi, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69578 )
Change subject: soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69578/comment/e8d85caf_1be55530
PS3, Line 16: 1
#1
https://review.coreboot.org/c/coreboot/+/69578/comment/5c77af36_0d9a2b0b
PS3, Line 19: Also add logs for each individual criteria so it's easy to tell why the
: overall Manufacturing Mode is set or not.
can you please point me to the section where added additional log ?
File src/soc/intel/meteorlake/me.c:
https://review.coreboot.org/c/coreboot/+/69578/comment/ea9bd7ae_3d4460ea
PS3, Line 83: EOM
`Manufacturing mode` instead EOM
https://review.coreboot.org/c/coreboot/+/69578/comment/fe9be488_99ad5568
PS3, Line 87: !!
why we need this? the logical statement should be enough to return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69578
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I495a7d8730716fc92e8c57b2caef73e8bb44d30b
Gerrit-Change-Number: 69578
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Tue, 15 Nov 2022 11:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment