Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Paul Menzel.
Angel Pons has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Cannon Lake)
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/lenovo/m920q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80609/comment/0f6fa08d_f37118c1?usp... :
PS7, Line 53: [0] = 1,
For M920Q M.2 SATA:
```suggestion
[0] = 1,
[4] = 1,
```
File src/mainboard/lenovo/m920q/gpio.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/4309297f_30eb51cf?usp... :
PS7, Line 6: /* Pad configuration was generated automatically using intelp2m utility */
Please tell intelp2m to generate the pretty macros (it's a command-line argument)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80609?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4
Gerrit-Change-Number: 80609
Gerrit-PatchSet: 7
Gerrit-Owner: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 03 Jun 2024 16:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No