Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29417 )
Change subject: src/soc/intel/braswell/acpi/lpss.asl: Remove SPI1 and PWM asl code
......................................................................
Patch Set 3:
Matt, could You please share Your opinion and possibly review the patch?
I'm not aware of these devices being used on any BSW Chromebook, but I can test the patch to be sure of no adverse reaction. Even though disabled by default, I'd only remove if we're sure that no BSW devices at all use these, otherwise may find ourselves reviewing a patch to add the code back and hook up the related UPD
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2ca7520081d00bf7a53d58ee054aa6f23e5606
Gerrit-Change-Number: 29417
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 04 Apr 2019 15:47:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment