Attention is currently required from: Bao Zheng, Zheng Bao, Arthur Heymans.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68389 )
Change subject: WIP:cbfstool: Expand the max size of image to 32M
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS2:
I'm pretty sure even AMD hardware does not memory map more than 16M.
only 16MByte of the flash can be mapped right below the 4GB boundary on AMD systems. https://review.coreboot.org/c/coreboot/+/66700/6//COMMIT_MSG goes a bit more into the details
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91e3488e6bf5748346c249ded723d3aa7b6f11b9
Gerrit-Change-Number: 68389
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 03 Nov 2022 13:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment