Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/asrock/e3c246d4i/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/19af758f_5731a562 PS2, Line 8: the hardware starting from closest to the cpu. */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/3c9b8d00_9175953f PS2, Line 8: the hardware starting from closest to the cpu. */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/b4501043_d69cb43a PS2, Line 10: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/5c7ee6eb_061a2fc4 PS2, Line 15: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/d178741b_b44acf45 PS2, Line 20: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310): https://review.coreboot.org/c/coreboot/+/56339/comment/d122fe1e_a83818ce PS2, Line 25: { that open brace { should be on the previous line