[L] Change in coreboot[main]: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer.

Lean Sheng Tan has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )

Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................

Patch Set 6:

(10 comments)

Patchset:

PS2:
> What are the differences? If possible I'd try to avoid creating variants (different firmware builds) […]

Acknowledged

File src/mainboard/hardkernel/odroid-h4/Kconfig:

https://review.coreboot.org/c/coreboot/+/83979/comment/d9f02cc7_694b6b6d?usp... :
PS4, Line 37: config NO_POST
            : 	default y
            :
> There's a FFC (Flat Flexible Cable) connector on the bottom of the board named "ESPI_DEBUG1", so I w […]

Done

File src/mainboard/hardkernel/odroid-h4/bootblock.c:

https://review.coreboot.org/c/coreboot/+/83979/comment/e152768a_252578b1?usp... :
PS4, Line 13: 	ite_reg_write(GPIO_DEV, 0x25, 0x01); // Enable Pin GP10
> What is GP10 used for? Seems unused on both schematics and in vendor firmware default settings (0x00 […]

Done

https://review.coreboot.org/c/coreboot/+/83979/comment/bc91c274_055f924f?usp... :
PS4, Line 14: 	ite_reg_write(GPIO_DEV, 0x27, 0x02); // Enable Pin GP31
> GP31 is used as CTS# so this should be removed too

Done

https://review.coreboot.org/c/coreboot/+/83979/comment/23b3a7b1_190d2cf8?usp... :
PS4, Line 15: 	ite_reg_write(GPIO_DEV, 0x28, 0x01); // Enable Pin GP40
> This seems to be used as PWRGD3, going to SYS_PWROK. I think this should be removed.

Done

https://review.coreboot.org/c/coreboot/+/83979/comment/bb8f32a4_564abdf9?usp... :
PS4, Line 16: Enable Pin GP50
> This is not GP50 (doesn't appear in the schematics), but the value matches vendor firmware.

Done

File src/mainboard/hardkernel/odroid-h4/gpio.h:

https://review.coreboot.org/c/coreboot/+/83979/comment/b8f1f16e_285a0a15?usp... :
PS4, Line 96: 	PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2),	/* UART0_TXD */
> This is not used

Done

File src/mainboard/hardkernel/odroid-h4/ramstage_fsp_params.c:

PS4:
> No license header

Done

https://review.coreboot.org/c/coreboot/+/83979/comment/cda0354b_b6700b3f?usp... :
PS4, Line 4: 
           : 	fsp_s_config->PchLegacyIoLowLatency = 1;
           : 	fsp_s_config->PchDmiAspmCtrl = 0;
> Why?

Done

File src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/83979/comment/ce9d7efc_685cdee5?usp... :
PS4, Line 29: TODO: Implement __weak variant_is_half_populated(void) function.
> Copy-pasta? This board has no variants, so this doesn't make much sense

Done