Attention is currently required from: Bao Zheng, Jason Nien, Al Hirani.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62911 )
Change subject: amdfwtool: Allow for 16 additional PSP entries to be supported.
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62911/comment/1fa4a5a3_2c840155
PS2, Line 9: Consolidate the MAX_BIOS_ENTRIES and MAX_PSP_ENTRIES definitions into one file
I'm sorry, would you be able to expand on that? I added periods at the end of sentences
I commented the dot/period I meant.
Commit Message:
https://review.coreboot.org/c/coreboot/+/62911/comment/73952a0c_e1120411
PS4, Line 7: .
I mean this dot/period. Please remove. [1]
[1]: https://cbea.ms/git-commit/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c64a1875010e7fb368967283df6baf1cc7ba8d
Gerrit-Change-Number: 62911
Gerrit-PatchSet: 4
Gerrit-Owner: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Comment-Date: Sat, 16 Apr 2022 08:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Al Hirani
al.hirani13@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment