Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth.
Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84562?usp=email )
Change subject: Makefile.mk: Remove Wno-packed-not-aligned flag
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84562/comment/07068a5a_6d99c811?usp... :
PS4, Line 8:
Well, these options are only applied if the compilation is not done with scan-build (see comment). […]
Elyes, *trivial* is always subjective, so please always write a commit message body.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84562?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8759603ff7b2c75e4a863a25c796781544be14ed
Gerrit-Change-Number: 84562
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 16 Oct 2024 05:55:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr