[M] Change in coreboot[main]: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware - coreboot-gerrit

25 Jul 2024


      Attention is currently required from: Forest Mittelberg, Julius Werner, Martin L Roth, Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83639?usp=email )
Change subject: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83639/comment/496af561_4ecf3781?usp... :
PS2, Line 73: CONFIG_EC_GOOGLE_CHROMEEC_FIRMWARE_FILE := $(call strip_quotes,$(CONFIG_EC_GOOGLE_CHROMEEC_FIRMWARE_FILE))
This line is still needed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie37ff3a188b414fd099fbb344858bca4df419086
Gerrit-Change-Number: 83639
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No