Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Sridhar Siricilla, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74435 )
Change subject: soc/intel/common: Fix long delay when ME is disabled
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74435/comment/6232ee0b_44c6a984
PS1, Line 14:
: This is because the current code only checks if the ME is
: disabled for CSE LITE SKUs. With this patch, boot times are
: approximately 5 seconds quicker:
So `cse_is_hfs1_com_soft_temp_disable()` took that long, and is skipped now with your patch from `&& […]
Honeslty, not quite sure exactly why. All cbmem shows is:
[ERROR] HECI: Prerequisites not met for sending EOP
[ERROR] HECI: timed out reading answer!
[ERROR] HECI: Failed to receive!
[DEBUG] HECI: Trigger HECI Reset
[ERROR] HECI: Prerequisites not met for sending EOP
[INFO ] CSE is disabled, continuing boot
[INFO ] Disabling Heci using PMC IPC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74435
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I182f30d4fbf43955747c6a7a0b284a43f9c5e4ef
Gerrit-Change-Number: 74435
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 13:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment