Change in coreboot[master]: soc/intel/{baytrail,braswell}: Drop unneeded `return`

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43193 )

Change subject: soc/intel/{baytrail,braswell}: Drop unneeded `return`
......................................................................

soc/intel/{baytrail,braswell}: Drop unneeded `return`

There's no reason to return the result of a void function.

Tested with BUILD_TIMELESS=1, Google Ninja remains identical.

Change-Id: I677dec1622768874a51effd6d73f0b2329f27aed
Signed-off-by: Angel Pons 
---
M src/soc/intel/baytrail/iosf.c
M src/soc/intel/braswell/iosf.c
2 files changed, 20 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/43193/1

diff --git a/src/soc/intel/baytrail/iosf.c b/src/soc/intel/baytrail/iosf.c
index 497dde40..5a83310 100644
--- a/src/soc/intel/baytrail/iosf.c
+++ b/src/soc/intel/baytrail/iosf.c
@@ -85,7 +85,7 @@

void iosf_usbphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
 }

uint32_t iosf_ushphy_read(int reg)
@@ -95,7 +95,7 @@

void iosf_ushphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USHPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USHPHY), reg, val);
 }

uint32_t iosf_lpss_read(int reg)
@@ -105,7 +105,7 @@

void iosf_lpss_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(LPSS), reg, val);
+	iosf_write_port(IOSF_WRITE(LPSS), reg, val);
 }

uint32_t iosf_ccu_read(int reg)
@@ -115,7 +115,7 @@

void iosf_ccu_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(CCU), reg, val);
+	iosf_write_port(IOSF_WRITE(CCU), reg, val);
 }

uint32_t iosf_score_read(int reg)
@@ -125,7 +125,7 @@

void iosf_score_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCORE), reg, val);
+	iosf_write_port(IOSF_WRITE(SCORE), reg, val);
 }

uint32_t iosf_scc_read(int reg)
@@ -135,7 +135,7 @@

void iosf_scc_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCC), reg, val);
+	iosf_write_port(IOSF_WRITE(SCC), reg, val);
 }

uint32_t iosf_aunit_read(int reg)
@@ -145,7 +145,7 @@

void iosf_aunit_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(AUNIT), reg, val);
+	iosf_write_port(IOSF_WRITE(AUNIT), reg, val);
 }

uint32_t iosf_cpu_bus_read(int reg)
@@ -155,7 +155,7 @@

void iosf_cpu_bus_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(CPU_BUS), reg, val);
+	iosf_write_port(IOSF_WRITE(CPU_BUS), reg, val);
 }

uint32_t iosf_sec_read(int reg)
@@ -165,7 +165,7 @@

void iosf_sec_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SEC), reg, val);
+	iosf_write_port(IOSF_WRITE(SEC), reg, val);
 }

uint32_t iosf_port45_read(int reg)
@@ -175,7 +175,7 @@

void iosf_port45_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x45), reg, val);
+	iosf_write_port(IOSF_WRITE(0x45), reg, val);
 }

uint32_t iosf_port46_read(int reg)
@@ -185,7 +185,7 @@

void iosf_port46_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x46), reg, val);
+	iosf_write_port(IOSF_WRITE(0x46), reg, val);
 }

uint32_t iosf_port47_read(int reg)
@@ -195,7 +195,7 @@

void iosf_port47_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x47), reg, val);
+	iosf_write_port(IOSF_WRITE(0x47), reg, val);
 }

uint32_t iosf_port55_read(int reg)
@@ -205,7 +205,7 @@

void iosf_port55_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x55), reg, val);
+	iosf_write_port(IOSF_WRITE(0x55), reg, val);
 }

uint32_t iosf_port58_read(int reg)
@@ -215,7 +215,7 @@

void iosf_port58_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x58), reg, val);
+	iosf_write_port(IOSF_WRITE(0x58), reg, val);
 }

uint32_t iosf_port59_read(int reg)
@@ -225,7 +225,7 @@

void iosf_port59_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x59), reg, val);
+	iosf_write_port(IOSF_WRITE(0x59), reg, val);
 }

uint32_t iosf_port5a_read(int reg)
@@ -235,7 +235,7 @@

void iosf_port5a_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x5a), reg, val);
+	iosf_write_port(IOSF_WRITE(0x5a), reg, val);
 }

uint32_t iosf_porta2_read(int reg)
@@ -245,7 +245,7 @@

void iosf_porta2_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0xa2), reg, val);
+	iosf_write_port(IOSF_WRITE(0xa2), reg, val);
 }

uint32_t iosf_ssus_read(int reg)
@@ -255,5 +255,5 @@

void iosf_ssus_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SSUS), reg, val);
+	iosf_write_port(IOSF_WRITE(SSUS), reg, val);
 }
diff --git a/src/soc/intel/braswell/iosf.c b/src/soc/intel/braswell/iosf.c
index a0d4b4f..11c44d0 100644
--- a/src/soc/intel/braswell/iosf.c
+++ b/src/soc/intel/braswell/iosf.c
@@ -94,7 +94,7 @@

void iosf_scc_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCC), reg, val);
+	iosf_write_port(IOSF_WRITE(SCC), reg, val);
 }

uint32_t iosf_usbphy_read(int reg)
@@ -104,7 +104,7 @@

void iosf_usbphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
 }

#if ENV_RAMSTAGE

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43193 )

Change subject: soc/intel/{baytrail,braswell}: Drop unneeded `return`
......................................................................

Patch Set 2: Code-Review+2

weird, I would have thought there would be nasty compiler warnings about this

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43193 )

Change subject: soc/intel/{baytrail,braswell}: Drop unneeded `return`
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+2
>
> weird, I would have thought there would be nasty compiler warnings about this

Same, but looks like you can return the result of a void function in a void function. Thanks for the review!

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43193 )

Change subject: soc/intel/{baytrail,braswell}: Drop unneeded `return`
......................................................................

soc/intel/{baytrail,braswell}: Drop unneeded `return`

There's no reason to return the result of a void function.

Tested with BUILD_TIMELESS=1, Google Ninja remains identical.

Change-Id: I677dec1622768874a51effd6d73f0b2329f27aed
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43193
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/baytrail/iosf.c
M src/soc/intel/braswell/iosf.c
2 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/soc/intel/baytrail/iosf.c b/src/soc/intel/baytrail/iosf.c
index 497dde40..5a83310 100644
--- a/src/soc/intel/baytrail/iosf.c
+++ b/src/soc/intel/baytrail/iosf.c
@@ -85,7 +85,7 @@

void iosf_usbphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
 }

uint32_t iosf_ushphy_read(int reg)
@@ -95,7 +95,7 @@

void iosf_ushphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USHPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USHPHY), reg, val);
 }

uint32_t iosf_lpss_read(int reg)
@@ -105,7 +105,7 @@

void iosf_lpss_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(LPSS), reg, val);
+	iosf_write_port(IOSF_WRITE(LPSS), reg, val);
 }

uint32_t iosf_ccu_read(int reg)
@@ -115,7 +115,7 @@

void iosf_ccu_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(CCU), reg, val);
+	iosf_write_port(IOSF_WRITE(CCU), reg, val);
 }

uint32_t iosf_score_read(int reg)
@@ -125,7 +125,7 @@

void iosf_score_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCORE), reg, val);
+	iosf_write_port(IOSF_WRITE(SCORE), reg, val);
 }

uint32_t iosf_scc_read(int reg)
@@ -135,7 +135,7 @@

void iosf_scc_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCC), reg, val);
+	iosf_write_port(IOSF_WRITE(SCC), reg, val);
 }

uint32_t iosf_aunit_read(int reg)
@@ -145,7 +145,7 @@

void iosf_aunit_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(AUNIT), reg, val);
+	iosf_write_port(IOSF_WRITE(AUNIT), reg, val);
 }

uint32_t iosf_cpu_bus_read(int reg)
@@ -155,7 +155,7 @@

void iosf_cpu_bus_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(CPU_BUS), reg, val);
+	iosf_write_port(IOSF_WRITE(CPU_BUS), reg, val);
 }

uint32_t iosf_sec_read(int reg)
@@ -165,7 +165,7 @@

void iosf_sec_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SEC), reg, val);
+	iosf_write_port(IOSF_WRITE(SEC), reg, val);
 }

uint32_t iosf_port45_read(int reg)
@@ -175,7 +175,7 @@

void iosf_port45_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x45), reg, val);
+	iosf_write_port(IOSF_WRITE(0x45), reg, val);
 }

uint32_t iosf_port46_read(int reg)
@@ -185,7 +185,7 @@

void iosf_port46_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x46), reg, val);
+	iosf_write_port(IOSF_WRITE(0x46), reg, val);
 }

uint32_t iosf_port47_read(int reg)
@@ -195,7 +195,7 @@

void iosf_port47_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x47), reg, val);
+	iosf_write_port(IOSF_WRITE(0x47), reg, val);
 }

uint32_t iosf_port55_read(int reg)
@@ -205,7 +205,7 @@

void iosf_port55_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x55), reg, val);
+	iosf_write_port(IOSF_WRITE(0x55), reg, val);
 }

uint32_t iosf_port58_read(int reg)
@@ -215,7 +215,7 @@

void iosf_port58_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x58), reg, val);
+	iosf_write_port(IOSF_WRITE(0x58), reg, val);
 }

uint32_t iosf_port59_read(int reg)
@@ -225,7 +225,7 @@

void iosf_port59_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x59), reg, val);
+	iosf_write_port(IOSF_WRITE(0x59), reg, val);
 }

uint32_t iosf_port5a_read(int reg)
@@ -235,7 +235,7 @@

void iosf_port5a_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0x5a), reg, val);
+	iosf_write_port(IOSF_WRITE(0x5a), reg, val);
 }

uint32_t iosf_porta2_read(int reg)
@@ -245,7 +245,7 @@

void iosf_porta2_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(0xa2), reg, val);
+	iosf_write_port(IOSF_WRITE(0xa2), reg, val);
 }

uint32_t iosf_ssus_read(int reg)
@@ -255,5 +255,5 @@

void iosf_ssus_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SSUS), reg, val);
+	iosf_write_port(IOSF_WRITE(SSUS), reg, val);
 }
diff --git a/src/soc/intel/braswell/iosf.c b/src/soc/intel/braswell/iosf.c
index a0d4b4f..11c44d0 100644
--- a/src/soc/intel/braswell/iosf.c
+++ b/src/soc/intel/braswell/iosf.c
@@ -94,7 +94,7 @@

void iosf_scc_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(SCC), reg, val);
+	iosf_write_port(IOSF_WRITE(SCC), reg, val);
 }

uint32_t iosf_usbphy_read(int reg)
@@ -104,7 +104,7 @@

void iosf_usbphy_write(int reg, uint32_t val)
 {
-	return iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
+	iosf_write_port(IOSF_WRITE(USBPHY), reg, val);
 }

#if ENV_RAMSTAGE