Attention is currently required from: Jason Glenesk, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74565 )
Change subject: soc/amd/phoenix/include/soc/pci_devs: update defines to match the PPR
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/74565/comment/3563ce2c_2827dcdd
PS1, Line 43: PCIE_GPP_2_1_FUNC
Thanks for making 1 = 1, the 0 = 1 was always very confusing.
the gpp bridge number always was off by one in the ppr; since we now have bridges on both device 1 and device 2, we moved over to using the device and function numbers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9429c03839bb0199a04cd6cafe9a955ebdacc91
Gerrit-Change-Number: 74565
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Wed, 19 Apr 2023 21:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment