[M] Change in coreboot[master]: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM

[Arthur Heymans (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Sridhar Siricilla.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )

Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM
......................................................................

Patch Set 16: Code-Review-1

(3 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74256/comment/20ff3711_fbc6e3fd 
PS16, Line 1154: 
               : static void cse_copy_fw_version(struct fw_version *dst, const struct fw_version *src)
               : {
               : 	if (src == NULL || dst == NULL) {
               : 		printk(BIOS_WARNING, "CSE: NULL value pointer provided for fw version copy.\n");
               : 		return;
               : 	}
               : 
               : 	dst->major = src->major;
               : 	dst->minor = src->minor;
               : 	dst->hotfix = src->hotfix;
               : 	dst->build = src->build;
               : }
Just use memcpy...

https://review.coreboot.org/c/coreboot/+/74256/comment/f471715c_931852cf 
PS16, Line 1250: if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && !s3wake) {
               : 		timestamp_add_now(TS_CSE_FW_SYNC_START);
               : 		cse_fw_sync();
               : 		timestamp_add_now(TS_CSE_FW_SYNC_END);
               : 
               : 		if (CONFIG(SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION))
               : 			store_cse_rw_fw_version();
               : 	}
               : }
The codeflow is quite confusing...  Can't you add store_cse_rw_fw_version in the same function call? Those functions for SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE and SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE look close to identical

https://review.coreboot.org/c/coreboot/+/74256/comment/3e41437f_ecb3ce25 
PS16, Line 1262: bool s3wake;
               : 	s3wake = acpi_get_sleep_type() == ACPI_S3;
               : 
               : 	if (s3wake)
               : 		return;
if (acpi_get_sleep_type() == ACPI_S3)
      return;