Attention is currently required from: Morris Hsu, Tarun Tuli.
Morris Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77242?usp=email )
Change subject: mb/google/brask/var/constitution: Separate wifi sar table ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/brya/variants/constitution/variant.c:
https://review.coreboot.org/c/coreboot/+/77242/comment/19f0e8de_cdff6117 : PS1, Line 7: CONSTITUTION_SKU_ID=0X0,
`spaces required around that '=' (ctx:VxV)`
Please fix.
https://review.coreboot.org/c/coreboot/+/77242/comment/7fd4880e_9d7a100d : PS1, Line 13: if(sku_id==CONSTITUTION_SKU_ID)
`spaces required around that '==' (ctx:VxV)`
Please fix.
https://review.coreboot.org/c/coreboot/+/77242/comment/3760ea71_a1b006d9 : PS1, Line 13: if(sku_id==CONSTITUTION_SKU_ID)
`space required before the open parenthesis '('`
Please fix.
https://review.coreboot.org/c/coreboot/+/77242/comment/604d4d98_d68c416e : PS1, Line 13: if(sku_id==CONSTITUTION_SKU_ID)
`that open brace { should be on the previous line`
Please fix.
https://review.coreboot.org/c/coreboot/+/77242/comment/56cadcad_23013922 : PS1, Line 17: else
`that open brace { should be on the previous line`
Please fix.
https://review.coreboot.org/c/coreboot/+/77242/comment/ee0a995d_df036c0f : PS1, Line 17: else
`else should follow close brace '}'`
Please fix.