Attention is currently required from: Sumeet Pawnikar, Furquan Shaikh, Paul Menzel, Sumeet R Pawnikar, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57290 )
Change subject: mb/google/brya/variants: fix override values for power limits
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57290/comment/5e224316_5748a69d
PS4, Line 9: There are two different types of 682 SKU available with TDP of 28W and 45W.
: This patch fix override values for power limits for these 682 SKU.
: This patch also sets power limit values dynamically based on machine ID and
: CPU TDP of SKU.
reflow for 72 characters wide please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I796e56321ae9c8312530a4b8986cd73a2245f5fa
Gerrit-Change-Number: 57290
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 16:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment