Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69042 )
Change subject: soc/intel/meteorlake: Remove PM Energy Report WA ......................................................................
soc/intel/meteorlake: Remove PM Energy Report WA
Disable Pch PM Energy Report WA was added to enhance boot time with HFPGA only. SoC needs reporting enabled.
BUG=None TEST=Build and Boot Google, Rex and Intel, MTLRVP without any boot time regression..
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: If5f1f9c6ab31652977d436a49a3531edffbd60c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69042 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/meteorlake/fsp_params.c 1 file changed, 20 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Sridhar Siricilla: Looks good to me, approved
diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index 4fd8f79..4fe2f63 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -375,14 +375,6 @@ s_cfg->PsOnEnable = 1; /* Enable the energy efficient turbo mode */ s_cfg->EnergyEfficientTurbo = 1; - - /* - * UPDATEME: This is WA for HFPGA - * Disable Pch Pm Energy Report - * Energy Report is disabled to enhance boottime with HFPGA. - */ - s_cfg->PchPmDisableEnergyReport = 1; - s_cfg->PmcLpmS0ixSubStateEnableMask = get_supported_lpm_mask(); }