Change in coreboot[master]: cpu/intel: Refactor platform_enter_postcar()

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )

Change subject: cpu/intel: Refactor platform_enter_postcar()
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... 
File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... 
PS2, Line 69: 	run_postcar_phase(&early_mtrrs);
> I am anticipating for the possibility of falling through to exit_car. […]

That's why postcar as introduced. You cannot rely on global variables in romstage w/o CAR_GLOBAL_MIGRATION and that whole API. I don't think tearing down CAR and bouncing back into a C program is appropriate. You can't really control how the cache will or won't evict cache lines.