Stanislaw Kaminski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 12:
I've created https://code.fe80.eu/lynxis/vbtparse to modify the vbt.
Surely took me a while, but I figured it out.
I used intel_vbt_decode tool to find what's different in VBT provided by you and the one from Coreboot tree (x230.vbt). Turns out that yours has header that says:
VBT signature: "$VBT SNB/IVB-MOBILE "
While the one provided in your patch is
VBT signature: "$VBT SANDYBRIDGE-M "
I have used your tool on x230.vbt from the tree, flashed, and now both Linux and Windows boot perfectly fine on FHD screen. Awesome!
I hope that you'll excuse me not proposing a merge for this - I'm not a developer by any means, and learning how to do that seems like an investment of time that I don't have. I'll be glad to upload my modified VBT wherever you please, though - just say the word.
And thanks for all the help you provided, and for your tool!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
derlafff@ya.ru
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: clayton craft
Gerrit-CC: slact
Gerrit-Comment-Date: Fri, 04 Dec 2020 08:38:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment