Attention is currently required from: John Su.
Paul Menzel has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85448?usp=email )
Change subject: mb/google/brya/var/uldrenite: Add HDA verb tables ......................................................................
Patch Set 5:
(6 comments)
Patchset:
PS5: Please send a follow-up to fix the style issues.
File src/mainboard/google/brya/variants/uldrenite/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/85448/comment/3aa3476b_335b5fa0?usp... : PS5, Line 7: 0x10ec0236, //Codec Vendor / Device ID: Realtek ALC3204 Please properly align the comment.
https://review.coreboot.org/c/coreboot/+/85448/comment/7ab5f565_0a642b96?usp... : PS5, Line 16: /* : * DMIC : * Requirement is to use PCH DMIC. Hence, : * commented out codec's Internal DMIC. : * AZALIA_PIN_CFG(0, 0x12, 0x90A60130), : * AZALIA_PIN_CFG(0, 0x13, 0x40000000), : */ Please align the asterisks.
https://review.coreboot.org/c/coreboot/+/85448/comment/dacb2eb2_31d2141e?usp... : PS5, Line 55: * + Combo Jack TRS setting */ Please use coreboot’s recommended concise multi-line comment styles.
https://review.coreboot.org/c/coreboot/+/85448/comment/02107709_6c211442?usp... : PS5, Line 143: //=== PCBeep pass through to NID14 for ePSA test-1 Why this strange comment style (===)?
https://review.coreboot.org/c/coreboot/+/85448/comment/3ac2b90f_507fadf3?usp... : PS5, Line 148: //=== PCBeep pass through to NID14 for ePSA test-2 Ditto.