Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62600 )
Change subject: commonlib/bsd: Remove cb_err_t
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
This patch breaks the TMP driver since 'cb_err_t' is used in src/security/tpm/tis.h.
The build error is:
In file included from src/drivers/pc80/tpm/tis.c:22:
src/security/tpm/tis.h:99:1: error: unknown type name 'cb_err_t'
99 | cb_err_t tis_vendor_write(unsigned int addr, const void *sendbuf, size_t send_size);
| ^~~~~~~~
src/security/tpm/tis.h:112:1: error: unknown type name 'cb_err_t'
112 | cb_err_t tis_vendor_read(unsigned int addr, void *recvbuf, size_t recv_size);
| ^~~~~~~~
make: *** [Makefile:382: build/bootblock/drivers/pc80/tpm/tis.o] Error 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaec36210d129db26d51f0a105d3de070c03b686b
Gerrit-Change-Number: 62600
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 09 Mar 2022 05:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment