Attention is currently required from: Arthur Heymans, Christian Walter, Nico Huber, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email )
Change subject: mb/emulation/riscv: Limit DRAM size
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I agree we may be better of just adding libfdt so we don't always need to unflatten it. […]
oh wait. I always confuse the naming scheme. You can also use FDT in coreboot without any heap usage. The `fdt_` prefixed functions should not do any unflatten but just directly read the blob. The `dt_` prefixed functions are only working on our internal `struct device_tree` representation and therefore require an unflatten of the blob.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68843?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515
Gerrit-Change-Number: 68843
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 10:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Gerrit-MessageType: comment