Attention is currently required from: Bora Guvendik, Jérémy Compostella, Kyoung Il Kim, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85197?usp=email )
Change subject: acpi/acpigen: generate Create*Field() from name string directly
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85197/comment/5613c250_d95df931?usp... :
PS1, Line 7: acpi/acpigen: generate Create*Field() from name string directly
nit: What do you mean by `directly` ?
There are set of acpigen_write_create_[byte/word/dword/qword]_field functions already, but the field can be be created from Arg[n] or Local[n] variable objects. A Name object must be first assigned to such variables. The new functions here will allow to create directly from Name object. Let me add more details in the comment messages.
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/85197/comment/e7a875e6_b3102a84?usp... :
PS1, Line 2441: byte
word_offset ?
offset in byte.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85197?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725f17329c501c80d42034e0f6a2fccb2cef5915
Gerrit-Change-Number: 85197
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 18:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com