Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59256 )
Change subject: util: Add coreboot-configurator
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS18:
Check for superfluous whitespace in the tree (lint-stable-003-whitespace): File Binary file util/coreboot-configurator/images/coreboot-configurator.gif matches has lines ending with whitespace.
test failed
seems that lint-stable-003-whitespace also checks the gif file which it shouldn't do and which broke the git commit hooks. would be good to fix the git commit hooks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I491922bf55ed87c2339897099634a38f8d055876
Gerrit-Change-Number: 59256
Gerrit-PatchSet: 18
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 19:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment