Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 )
Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/60379/comment/0ee0c55c_14f800d3
PS2, Line 25: def_bool y
In case of you move it out, please have a look at CB:60371 before. […]
Finally I have address the CL as you and Eric might have suggested.
Please take a look the newer patchset.
https://review.coreboot.org/c/coreboot/+/60379/comment/f0a96db5_21f1a2d7
PS2, Line 60:
Ideally we wish to guard BOARD_GOOGLE_BRYA_COMMON (now BOARD_SPECIFIC_OPTIONS) using an if clause, I […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e
Gerrit-Change-Number: 60379
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 25 Dec 2021 17:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment