Attention is currently required from: Reka Norman, Nico Huber, Jeremy Soller, Nick Vaccaro, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60143 )
Change subject: drivers/intel/pmc_mux/conn: Change usb{23}_port_number fields to device pointers
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
Very clean, I love it!
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/60143/comment/d6536a35_af9a1fce
PS2, Line 60: path.usb.port_id + 1
Idea: Put this into a helper function:
static unsigned int get_usb_port_number(const struct device *usb_port)
{
return usb_port->path.usb.port_id + 1;
}
And call it with `config-›usb2_port` or `config-›usb3_port` as argument
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5045b8ea57e8ca6f9ebd7d68a19486736b7e2809
Gerrit-Change-Number: 60143
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 17 Dec 2021 10:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment