Attention is currently required from: Felix Singer, Ariel Fang, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 )
Change subject: mb/google/brya/var/primus: Follow the schematic to modify the gpio pin to none.
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60104/comment/9fe5c1f0_214897c2
PS9, Line 9: - Modify the gpio pin to none.
Explain the issue and why this patch fixes the issue.
I think what we're getting at here is a few GPIOs were missed during the initial review, and this fixes those oversights.
https://review.coreboot.org/c/coreboot/+/60104/comment/1fb3aa6d_06400d3c
PS9, Line 11: B
Missing number?
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/60104/comment/84dc80a7_c626ff71
PS12, Line 7: Follow the schematic to modify the gpio pin to none.
suggestion:
```
mb/google/brya/var/primus: Fix some GPIO programming
During the initial review, a few unused GPIOs that were inherited
from the baseboard were missed, so this CL programs them as PAD_NC.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98
Gerrit-Change-Number: 60104
Gerrit-PatchSet: 12
Gerrit-Owner: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 Dec 2021 19:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment