Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 )
Change subject: soc/intel/tigerlake: Hook up FSP repository
......................................................................
Patch Set 7:
I can only give a +1 because there's a Tigerlake UP3 reference board in the tree, which would need the IOT version of FSP.
For reference, UP3: IOT, UP4: Client.
Oh, yes. Thanks! I am not sure if UP4 is the Client version (the FSP repo doesn't mention UP4 anywhere), but some news sites are saying so.
So I would just add another Kconfig option for differentiation UP3 / UP4.
What should I use for the extension? UP3 / UP4 or IOT / CLIENT?
_IOT vs _CLIENT sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7
Gerrit-Change-Number: 48713
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Sat, 02 Jan 2021 13:54:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment