Attention is currently required from: Anil Kumar K, Bora Guvendik, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )
Change subject: src/lib: Add Kconfig variable for fw_config default value
......................................................................
Patch Set 2:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83153/comment/34df8c9b_d20df773?usp... :
PS2, Line 548: 0x00000
unable to follow the motivation. […]
Good point! This is used in make build environment where no CBI value is synced from config.star. Also, with this flag been overridden in config.<board>, the different fw_config value can be tested while it is not provided from Chrome EC and VPD. For instance, in simulation environment, the targeted overridden value can be used with the need of updating the value in the storage model prior to boot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83153?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
Gerrit-Change-Number: 83153
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 19:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com