Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
oprom/yabel: Fix comment to fix the build
Old comment did not match the pattern required to not flag the fall-through as an error.
Change-Id: I2afaca969c295a5dc4389dad0ce898c87bb841a6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/device/oprom/yabel/io.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/34578/1
diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index e8c41ce..051a601 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -184,8 +184,7 @@ X86EMU_trace_on(); } M.x86.debug &= ~DEBUG_DECODE_NOPRINT_F; - //HALT_SYS(); - // no break, intentional fall-through to default!! + // fall-through default: DEBUG_PRINTF_IO ("%s(%04x) reading from bios_device.io_buffer\n",
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
Patch Set 1: Code-Review+2
Hmmm, was this not hooked up to the build system before?
Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
Patch Set 1:
It was hooked up - I added had to localy fix it, when dpoing the option rom things - was still looking into it, if it were my fault or the codes..
Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34578 )
Change subject: oprom/yabel: Fix comment to fix the build ......................................................................
oprom/yabel: Fix comment to fix the build
Old comment did not match the pattern required to not flag the fall-through as an error.
Change-Id: I2afaca969c295a5dc4389dad0ce898c87bb841a6 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34578 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jacob Garber jgarber1@ualberta.ca Reviewed-by: Johanna Schander coreboot@mimoja.de Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/device/oprom/yabel/io.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Johanna Schander: Looks good to me, but someone else must approve Jacob Garber: Looks good to me, approved
diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index e8c41ce..051a601 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -184,8 +184,7 @@ X86EMU_trace_on(); } M.x86.debug &= ~DEBUG_DECODE_NOPRINT_F; - //HALT_SYS(); - // no break, intentional fall-through to default!! + // fall-through default: DEBUG_PRINTF_IO ("%s(%04x) reading from bios_device.io_buffer\n",
-
Jacob Garber (Code Review) -
Johanna Schander (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)