Cliff Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83980?usp=email )
Change subject: soc/intel/common/tcss: Move AUX bias ctrl register field defines to TCSS SOC header ......................................................................
soc/intel/common/tcss: Move AUX bias ctrl register field defines to TCSS SOC header
These field defines are SOC-specific.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: I0f9c895590465b2f539c91834cf331fcd7efa996 --- M src/soc/intel/alderlake/include/soc/tcss.h M src/soc/intel/common/block/tcss/tcss.c M src/soc/intel/meteorlake/include/soc/tcss.h M src/soc/intel/tigerlake/include/soc/tcss.h 4 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/83980/1
diff --git a/src/soc/intel/alderlake/include/soc/tcss.h b/src/soc/intel/alderlake/include/soc/tcss.h index 825b6c7..079d3bc 100644 --- a/src/soc/intel/alderlake/include/soc/tcss.h +++ b/src/soc/intel/alderlake/include/soc/tcss.h @@ -17,4 +17,7 @@ #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 0x1088 #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET(x) (IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 + (x) * 4)
+#define BIAS_CTRL_VW_INDEX_SHIFT 16 +#define BIAS_CTRL_BIT_POS_SHIFT 8 + #endif /* _SOC_TCSS_H_ */ diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 5ebc129..1ca51a2 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -18,8 +18,6 @@ #include <soc/tcss.h> #include <drivers/intel/pmc_mux/conn/chip.h>
-#define BIAS_CTRL_VW_INDEX_SHIFT 16 -#define BIAS_CTRL_BIT_POS_SHIFT 8 #define WAIT_FOR_DISPLAYPORT_TIMEOUT_MS 1000 #define WAIT_FOR_DP_MODE_ENTRY_TIMEOUT_MS 1500 #define WAIT_FOR_HPD_TIMEOUT_MS 3000 diff --git a/src/soc/intel/meteorlake/include/soc/tcss.h b/src/soc/intel/meteorlake/include/soc/tcss.h index 014e307..5fa1da4 100644 --- a/src/soc/intel/meteorlake/include/soc/tcss.h +++ b/src/soc/intel/meteorlake/include/soc/tcss.h @@ -13,4 +13,7 @@ #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 0x1088 #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET(x) (IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 + (x) * 4)
+#define BIAS_CTRL_VW_INDEX_SHIFT 16 +#define BIAS_CTRL_BIT_POS_SHIFT 8 + #endif /* _SOC_TCSS_H_ */ diff --git a/src/soc/intel/tigerlake/include/soc/tcss.h b/src/soc/intel/tigerlake/include/soc/tcss.h index 014e307..5fa1da4 100644 --- a/src/soc/intel/tigerlake/include/soc/tcss.h +++ b/src/soc/intel/tigerlake/include/soc/tcss.h @@ -13,4 +13,7 @@ #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 0x1088 #define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET(x) (IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 + (x) * 4)
+#define BIAS_CTRL_VW_INDEX_SHIFT 16 +#define BIAS_CTRL_BIT_POS_SHIFT 8 + #endif /* _SOC_TCSS_H_ */