Attention is currently required from: Jeff Li.
Hello Jeff Li,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/75738?usp=email
to review the following change.
Change subject: soc/intel/xeon_sp: Fix HEST table length ......................................................................
soc/intel/xeon_sp: Fix HEST table length
"current" points to the start of HEST table, so "next - current" already includes the size of its header, no need for increment here.
Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db Signed-off-by: Jeff Li lijinfeng01@inspur.com Signed-off-by: Ziang Wang ziang.wang@intel.com --- M src/soc/intel/xeon_sp/ras/hest.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/75738/1
diff --git a/src/soc/intel/xeon_sp/ras/hest.c b/src/soc/intel/xeon_sp/ras/hest.c index 9eb54d9..2da720a 100644 --- a/src/soc/intel/xeon_sp/ras/hest.c +++ b/src/soc/intel/xeon_sp/ras/hest.c @@ -65,7 +65,7 @@ next = hest + 1; next += acpi_hest_add_ghes(next); hest->error_source_count += 1; - header->length += next - current; + header->length = next - current; return header->length; }