Attention is currently required from: Paul Menzel, Angel Pons, Michael Niewöhner. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 )
Change subject: arch/x86/smbios: Add generation of type 20 table ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58271/comment/e4363307_bb0d427a PS2, Line 10: type 20
Could you please explain what the "type 20" SMBIOS table is about? At least mention the name in the […]
Done
https://review.coreboot.org/c/coreboot/+/58271/comment/83f78413_2a8ef336 PS2, Line 10: from type 17/19 tables to generate type 20 SMBIOS table
Missing a period.
Done
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/58271/comment/b566e230_ef03e02c PS2, Line 1038: sizeof(struct smbios_type20)
Please don't. […]
Done
https://review.coreboot.org/c/coreboot/+/58271/comment/46b933b3_9aca6dd3 PS2, Line 1042: ++
Dead increment
Done
https://review.coreboot.org/c/coreboot/+/58271/comment/859f34d2_347504f8 PS2, Line 1046: 0xFF
nit: use lowercase for hex values
Done
https://review.coreboot.org/c/coreboot/+/58271/comment/2177d484_1ce51977 PS2, Line 1051: t->length = len - 2;
Please use `smbios_carve_table` added in CB:55907 and `smbios_full_table_len` added in CB:55909
Done
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/58271/comment/00e6888f_22838c02 PS2, Line 885: u8 type; : u8 length; : u16 handle;
Please use `struct smbios_header header;` instead, like the other tables do.
Done