Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Arthur Heymans, Kyösti Mälkki, Aaron Durbin, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54299 )
Change subject: arch/x86/postcar: Set up postcar MTRR in C code
......................................................................
Patch Set 11:
(3 comments)
File src/arch/x86/postcar.c:
https://review.coreboot.org/c/coreboot/+/54299/comment/f17092ea_6acd91b9
PS11, Line 3: #include <cpu/x86/msr.h>
u can put this in order, rest looks good.
File src/cpu/x86/mtrr/earlymtrr.c:
https://review.coreboot.org/c/coreboot/+/54299/comment/04520047_26ab6207
PS11, Line 126: for (int i = 0; i < ctx->max_var_mtrrs; i++) {
: wrmsr(MTRR_PHYS_BASE(i), zero);
: wrmsr(MTRR_PHYS_MASK(i), zero);
: }
can't u use clear_all_var_mtrr() here ?
https://review.coreboot.org/c/coreboot/+/54299/comment/002e6140_6cd5ef72
PS11, Line 131: wrmsr(MTRR_PHYS_BASE(i), ctx->mtrr[i].base);
: wrmsr(MTRR_PHYS_MASK(i), ctx->mtrr[i].mask);
set_var_mtrr() may be ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ec10e84118197a04de0a5194336ef8bb049bba4
Gerrit-Change-Number: 54299
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 02 Apr 2022 13:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment