Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31713 )
Change subject: drivers/intel/fsp1_0: Deduplicate code ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31713/1/src/drivers/intel/fsp1_0/fsp_util.c File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/31713/1/src/drivers/intel/fsp1_0/fsp_util.c@... PS1, Line 109: oid ChipsetFspReturnPoint(EFI_STATUS Status, VOID *HobListPtr)
Once there is no external caller more for this function should we make it static and remove it from […]
Done
https://review.coreboot.org/#/c/31713/1/src/drivers/intel/fsp1_0/fsp_util.c@... PS1, Line 113: if (Status == 0xFFFFFFFF) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/31713/1/src/soc/intel/fsp_baytrail/fsp/chips... File src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c:
https://review.coreboot.org/#/c/31713/1/src/soc/intel/fsp_baytrail/fsp/chips... PS1, Line 22:
This is still needed here (in chipset_fsp_early_init()), just add it back again.
Done
-
Patrick Rudolph (Code Review)