Attention is currently required from: Anil Kumar K, Eran Mitrani, Hannah Williams, Jakub Czapiga, Kapil Porwal, Krishna P Bhat D, Rizwan Qureshi, Tarun, Tarun Tuli, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76115?usp=email )
Change subject: soc/intel/mtl: Select SOC_INTEL_CSE_LITE_PSR config for Meteorlake
......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/76115/comment/0348f4ab_41b9ac80 :
PS11, Line 29: select SOC_INTEL_CSE_LITE_PSR
agreed . that was the reason in my patch i call this just before issuing backup PSR command, so we do a switch only when we are in downgrade scenario.
have you filed a bug already for CSE? if not please raise a partner bug to track this part. This is not an improvement for say.
I'm marking this resolve w/ understanding that sending PSR backup cmd for non-vpro sku is harmless.
btw, please take a look into below comments as well.
https://review.coreboot.org/c/coreboot/+/74577/comment/659d6050_b159441d/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76115?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39af029a5f0c018a5db3ac68191764abfa9518ac
Gerrit-Change-Number: 76115
Gerrit-PatchSet: 13
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 09:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment