Change in coreboot[master]: soc/intel/alderlake, soc/common: Add method to determine the cpu type
Attention is currently required from: Arthur Heymans, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )
Change subject: soc/intel/alderlake, soc/common: Add method to determine the cpu type ......................................................................
Patch Set 5:
(4 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/59360/comment/751c0a42_9736a598 PS1, Line 18: get_cpu_type
Done,
Done
https://review.coreboot.org/c/coreboot/+/59360/comment/8a51e9e4_a50a5ea0 PS1, Line 23: get_cpu_type_bitmask
This is implemented in the cpu_hybrid.c. […]
Done
https://review.coreboot.org/c/coreboot/+/59360/comment/a4d25dec_25d5942d PS1, Line 25: return global_cpu_type_bitmask;
set_cpu_type_bitmask() is run in multi core context during BS_DEV_INIT_CHIPS, but global_cpu_type_b […]
Done
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/59360/comment/6546d29d_f43b9e65 PS3, Line 37: set_cpu_type_bitmask
I agree with you, since bitmask is 32 bits, it wont' scale up beyond 32 cores. […]
Done
-
Sridhar Siricilla (Code Review)