Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans, Kyösti Mälkki. Дмитрий Понаморев has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/57196 )
Change subject: mb/teleplatforms/D4E4S168: Add blobs ......................................................................
Patch Set 7:
(7 comments)
Commit Message:
https://review.coreboot.org/c/blobs/+/57196/comment/265124b9_f01b5ca8 PS4, Line 7: 3rdparty/blobs/mainboard/teleplatforms/D4E4S16P8
Maybe: […]
Done
https://review.coreboot.org/c/blobs/+/57196/comment/1df78200_d63adcb7 PS4, Line 7: 3rdparty/blobs/mainboard/teleplatforms/D4E4S16P8: Create new folder for teleplatforms/D4E4S16P8 CRB.
No dot/period at the end of commit message summaries please [1]. […]
Done
https://review.coreboot.org/c/blobs/+/57196/comment/313c1cf8_c0708e92 PS4, Line 9: compile
build
Done
https://review.coreboot.org/c/blobs/+/57196/comment/fa8ed1be_664f35df PS4, Line 11:
Blobs must be accompanied by a distribution license, which must allow unlimited redistribution. […]
Done
Patchset:
PS4:
Maybe also list the versions of the other components (ME, FSP, …).
Done
File mainboard/teleplatforms/D4E4S16P8/README.md:
https://review.coreboot.org/c/blobs/+/57196/comment/b9ea6a45_8f03ecf7 PS5, Line 1: contens
typo: conten*t*s
Done
File mainboard/teleplatforms/D4E4S16P8/bootorder:
https://review.coreboot.org/c/blobs/+/57196/comment/9cacdef9_021b87db PS5, Line 1: /pci@i0cf8/usb@15/usb-*@1 : /pci@i0cf8/usb@15/usb-*@2 : /pci@i0cf8/usb@15/usb-*@3 : /pci@i0cf8/usb@15/usb-*@4 : /pci@i0cf8/*@13/drive@1/disk@0 : /pci@i0cf8/*@13/drive@3/disk@0
+1, I agree this can be in the mainboard directory
Done
-
Дмитрий Понаморев (Code Review)