Attention is currently required from: Felix Singer, Sean Rhodes, Jeremy Soller, Nick Vaccaro, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59883 )
Change subject: soc/intel/tigerlake: Hook up SMBus device to devicetree
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59883/comment/490d20d9_c62607a7
PS7, Line 13: despite SmbusEnable is not set.
`despite` (and `in spite of`) need to be followed by a noun, a gerund or `the fact that` + subordinate clause:
despite SmbusEnable not being set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59883
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0789af20beb147fc1a6a7d046cdcea15cb44ce4c
Gerrit-Change-Number: 59883
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 07 Dec 2021 13:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment