Attention is currently required from: Arthur Heymans, Paul Menzel, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS5:
Should change the wording and format hmm.
Done
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/a0a4b75b_fb488ca9 :
PS5, Line 263: if (code >= 0x01 && code <= 0x23)
: return type[code - 0x01];
: return "Unsupported memory type";
I don't expect the old project want to select this config, we can save some static memories :p
Done
https://review.coreboot.org/c/coreboot/+/75756/comment/f61717bd_dec7ced8 :
PS5, Line 1046:
b/c this would need check many things if empty slot. so I add in create_smbios_type17_for_dimm. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b5ca1f4a59598531a6cba500672c2717f2a7b00
Gerrit-Change-Number: 75756
Gerrit-PatchSet: 7
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 13 Jun 2023 02:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment