Attention is currently required from: Felix Singer, Jérémy Compostella, Subrata Banik.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83708?usp=email )
Change subject: soc/intel/cml, pci_ids: Fix ID for Comet Lake-H GT2
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83708/comment/804ec87f_57f9e78e?usp... :
PS8, Line 41: Fix the corresponding IDs and remove duplicate entries.
It's not clear to me which of them are duplicates and why they are duplicates. […]
Thx for the review.
I agree, the commit is quite confusing. I tried to split the patch to make more sense of it:
CB:83708
CB:83861
CB:83862
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83708?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Gerrit-Change-Number: 83708
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Sat, 10 Aug 2024 09:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de